[20121] Remove unnecessary TCP warning #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepemi
force-pushed
the
bugfix/remove_send_unnecessary_warning
branch
from
1bb9ffc
to
ce1f0dd
Compare
|
@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x |
✅ Backports have been created
|
jepemi
force-pushed
the
bugfix/remove_send_unnecessary_warning
branch
from
ce1f0dd
to
7cda21f
Compare
|
@richiprosima please test this |
MiguelCompany
approved these changes
Jan 16, 2024
|
@richiprosima please test mac test discovery_server_linux |
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
jepemi
force-pushed
the
bugfix/remove_send_unnecessary_warning
branch
from
7cda21f
to
26a3402
Compare
|
@richiprosima please test this |
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
This was referenced Jan 22, 2024
JesusPoderoso
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
EduPonz
pushed a commit
that referenced
this pull request
Jan 25, 2024
EduPonz
pushed a commit
that referenced
this pull request
Jan 27, 2024
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
MiguelCompany
pushed a commit
that referenced
this pull request
Jan 29, 2024
EduPonz
pushed a commit
that referenced
this pull request
Feb 1, 2024
jepemi
added a commit
that referenced
this pull request
Feb 23, 2024
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
EduPonz
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Remove unnecessary warning (#4217) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226) * Refs #20485: Fix tests using PubSubParticipant Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20485: PubSubBasic test fix Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Remove unnecessary warning (#4217) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226) * Fix wrong log info messages on TCP (#4258) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 36f7f57) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp * Refs #20262: Resolve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When sending TCP messages, the locator selector from the publisher includes the locators to which messages will be sent. These locators are compared with the send_resource_list_. If there are more than two endpoints available (locators A and B), the following checks are made: A==A, A==B, B==A, B==B.
Successful checks end in trying to send data to the correspondent locator.
Mismatching checks produce a warning, though it is actually correct behavior.
@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist